Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request for Pathways Interactions byEntity #21

Open
RyAMiller opened this issue May 4, 2016 · 7 comments
Open

Feature Request for Pathways Interactions byEntity #21

RyAMiller opened this issue May 4, 2016 · 7 comments

Comments

@RyAMiller
Copy link

One thing Peter pointed out when testing was that when specifically looking at the Interactions/byEntity calls was that we should also use the 'type' of interaction it is. Getting information about what sort of interaction it is is useful when looking for places to stop (for example: an inhibition event). Adding the type should be easy enough, it is already in the RDF and only requires an additional one line to the query used in the call. Something along the lines of ' a ?type ' and then use ?type as a variable.

@stain
Copy link
Contributor

stain commented May 5, 2016

Could you give example of which API calls should add which types? I can't find any additional types beyond DirectedInteraction and Interaction on the example call

@stain
Copy link
Contributor

stain commented May 5, 2016

So say in interactions with ENSBTAG00000048213 you would want to include:

<http://rdf.wikipathways.org/Pathway/WP1065_r80781/WP/Interaction/b23fd> rdf:type ns0:DirectedInteraction, ns0:Inhibition ;
      ns1:source <http://identifiers.org/ensembl/ENSBTAG00000048213> ;
      ns1:target <http://identifiers.org/ensembl/ENSBTAG00000005359> .

?

@stain
Copy link
Contributor

stain commented May 5, 2016

Now added on ops2 - please check and then we can squeeze it in for 2.1.

note that this means that the for the interaction sometimes is an array in JSON or nested in XML:

<item href="http://rdf.wikipathways.org/Pathway/WP1065_r80781/WP/Interaction/d28eb">
    <type>
        <item href="http://vocabularies.wikipathways.org/wp#Inhibition"/>
        <item href="http://vocabularies.wikipathways.org/wp#DirectedInteraction"/></type>
        <target href="http://identifiers.org/ensembl/ENSBTAG00000010671">
           <type>
              <item href="http://vocabularies.wikipathways.org/wp#GeneProduct"/>
              <item href="http://vocabularies.wikipathways.org/wp#Protein"/>
           </type>
(..)

(but as you see this was already the case with the source and target types)

stain added a commit that referenced this issue May 5, 2016
e.g. wp:Interaction

This fixes issue #21
@stain
Copy link
Contributor

stain commented May 5, 2016

Probably needs to be added to the swagger file documentation to indicate the optional array of ?types in orange background

@PeterWoollard
Copy link

Thanks Stain, that looks good to me.
This adds a lot of value. Yes it would be great if this can be squeezed into the 2.1 release.
Any concerns Ryan?

stain added a commit that referenced this issue May 9, 2016
e.g. wp:Interaction

This fixes issue #21
@stain
Copy link
Contributor

stain commented May 9, 2016

Thanks, then I think we can deploy this.

@ghard - could you do a git pull on the 2.1 branch on the API? That should deploy this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants