Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Refactor the code of consoles #35

Open
bowen-xu opened this issue Oct 17, 2023 · 2 comments
Open

[Feature] Refactor the code of consoles #35

bowen-xu opened this issue Oct 17, 2023 · 2 comments
Assignees
@bowen-xu
Labels
enhancement New feature or request

Comments

@bowen-xu
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Now there are several files for Consoles: Console.py, CnosoleMC.py, ConsolePlus.py, Interface.py
They should be merged into a single file to implement Console.
@bowen-xu bowen-xu added the enhancement New feature or request label Oct 17, 2023
@bowen-xu bowen-xu self-assigned this Oct 17, 2023
@ARCJ137442
Copy link
Contributor

ARCJ137442 commented Oct 17, 2023 •
edited
Loading

Maybe they can be aggregated into a new module, such as "io" or "userInterface".
I also considered to make a websocket-based IO channel for PyNARS based on websockets recently. Hope this will not make things more messy.

@bowen-xu
Copy link
Collaborator Author

@ARCJ137442 I am working on GUI and adopt websocket to do communication among processes. Websocket is a low-level protocal, so I wrote a RPC package based on websocket.
See https://github.com/bowen-xu/PyNARS/issues/7#issuecomment-1722370004, the rpc repo and branch gui

@ARCJ137442 ARCJ137442 mentioned this issue Oct 18, 2023
Merged
@ARCJ137442 ARCJ137442 mentioned this issue May 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bowen-xu bowen-xu

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bowen-xu @ARCJ137442