Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-Language Support: don't reply with all languages #32

Open
tulshi opened this issue Jun 28, 2023 Discussed in #26 · 5 comments
Open

Multi-Language Support: don't reply with all languages #32

tulshi opened this issue Jun 28, 2023 Discussed in #26 · 5 comments

Comments

@tulshi
Copy link
Collaborator

tulshi commented Jun 28, 2023

Discussed in #26

Originally posted by baboulebou June 28, 2023
I don't think it's a good idea to reply with all language strings, this could be a huge response and it would probably slow-down the PDP too. Instead, have the client PEP request the language it wants its responses in, and just return that 1 reason string.
==> This requires adding a Language parameter to the request calls.

@rlenglet
Copy link

rlenglet commented Jul 6, 2023

Why couldn't we use standard HTTP language negotiation using the Accept-Language header?
https://www.rfc-editor.org/rfc/rfc9110.html#name-accept-language

@baboulebou
Copy link
Collaborator

I like this idea...

@davidjbrossard
Copy link
Collaborator

davidjbrossard commented Jul 7, 2023 via email

@rlenglet
Copy link

rlenglet commented Jul 7, 2023

@davidjbrossard you're probably referring to the Accept header (not Accept-Language)?
https://www.rfc-editor.org/rfc/rfc9110.html#name-accept

@davidjbrossard
Copy link
Collaborator

davidjbrossard commented Jul 7, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants