Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicate icons #3035

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

brian-smith-tcril
Copy link
Contributor

@brian-smith-tcril brian-smith-tcril commented Apr 25, 2024

Description

In #3029 extra icons were added with names that were identical except for capitalization.

Unfortunately CI didn't catch this because the generated icons were there, so running an icon build didn't lead to a git diff. (PR to fix that is up here: #3036)

- name: Verify icon changes
run: |
cd icons
npm run build
if [[ -n $(git status -s) ]]; then
echo "::error::Generated icons do not match committed icons. Please run \`npm run build\` in the icons directory."
exit 1
fi

I removed all Lms* icons from the icons/es5 and icons/jsx directories and re-ran an icon build.

Thank you @bradenmacdonald for catching this here #3029 (comment)

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please request an a11y review for the PR in the #wg-paragon Open edX Slack channel.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c088b28
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/662ab9fcff5d950008d8d7e1
😎 Deploy Preview https://deploy-preview-3035--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solves the bug I was seeing in git. Thanks!

@arbrandes arbrandes merged commit 2557a95 into openedx:master Apr 26, 2024
8 checks passed
@openedx-semantic-release-bot

🎉 This PR is included in version 22.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants