chore(deps): updated frontend-build & frontend-platform major versions #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BilalQamar95
changed the title
…-application into bilalqamar95/jest-v29-upgrade
…-application into bilalqamar95/jest-v29-upgrade
|
@BilalQamar95 this PR has conflicts, can you update so that it can be reviewed and merged? |
…-application into bilalqamar95/jest-v29-upgrade
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #701 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 2 2
Lines 7 7
======================================
Misses 7 7 ☔ View full report in Codecov by Sentry. |
package.json
Outdated
| @@ -36,7 +36,7 @@ | |||
| "dependencies": { | |||
| "@edx/brand": "npm:@openedx/brand-openedx@^1.2.2", | |||
| "@edx/frontend-component-header": "5.3.3", | |||
| "@edx/frontend-platform": "7.1.4", | |||
| "@edx/frontend-platform": "8.0.0", | |||
There was a problem hiding this comment.
The latest version of platform is 8.0.4 - is there a specific reason to keep this pinned to an exact version? It seems just using ^8.0.0 might be a reasonable option here.
brian-smith-tcril
approved these changes
Jul 5, 2024
brian-smith-tcril
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
frontend-buildto v14 &frontend-platformto v8 along with respective edx packagesjesttov29snapshotsfor failing tests