Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: enable frontend-multiprocessing parametrization #84

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dtrifiro
Copy link
Contributor

@dtrifiro dtrifiro commented Aug 6, 2024

Revert "tests: temporarily disable frontend multiprocessing parametrization"

@dtrifiro

This comment was marked as outdated.

@dtrifiro
Copy link
Contributor Author

dtrifiro commented Aug 7, 2024

Tests pass with parametrization enabled, but pytest exists with error:

================== 13 passed, 2 skipped, 4 warnings in 25.39s ==================
--- Logging error ---
Fatal Python error: _enter_buffered_busy: could not acquire lock for <_io.BufferedWriter name='<stderr>'> at interpreter shutdown, possibly due to daemon threads
Python runtime state: finalizing (tstate=0x00007f8973376358)

Current thread 0x00007f8973439b80 (most recent call first):
  <no Python frame>

This is probably related to the way we spin up vLLM in a loop in a separate thread in the _servers fixture.

@dtrifiro dtrifiro changed the title tests: enable parametrization tests: enable frontend-multiprocessing parametrization Aug 7, 2024
@dtrifiro dtrifiro mentioned this pull request Aug 7, 2024
@dtrifiro dtrifiro force-pushed the enable-test-parametrization branch from 39b3455 to 8c51527 Compare August 7, 2024 11:51
@dtrifiro dtrifiro marked this pull request as draft August 13, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant