updates for vLLM==0.5.4 #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtrifiro
force-pushed
the
get-rid-of-upstream-code
branch
from
1929349
to
ba26eb6
Compare
dtrifiro
commented
Aug 6, 2024
dtrifiro
commented
Aug 6, 2024
dtrifiro
force-pushed
the
get-rid-of-upstream-code
branch
from
ba26eb6
to
9b568a3
Compare
dtrifiro
commented
Aug 6, 2024
| http_server_task = loop.create_task(run_http_server(engine, args, model_config)) | ||
| grpc_server_task = loop.create_task( | ||
| run_grpc_server( | ||
| engine, args, disable_log_stats=engine_args.disable_log_stats |
There was a problem hiding this comment.
Note that I've gotten rid of the disable_log_stats argument, as the _force_log coroutine is scheduled as part of the lifespan attribute of the fastapi server.
dtrifiro
force-pushed
the
get-rid-of-upstream-code
branch
3 times, most recently
from
e1bda2a
to
aab12db
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
==========================================
- Coverage 62.73% 61.13% -1.60%
==========================================
Files 18 20 +2
Lines 1280 1181 -99
Branches 227 209 -18
==========================================
- Hits 803 722 -81
+ Misses 399 383 -16
+ Partials 78 76 -2 ☔ View full report in Codecov by Sentry. |
dtrifiro
commented
Aug 6, 2024
dtrifiro
commented
Aug 6, 2024
dtrifiro
commented
Aug 6, 2024
| if (device_type := engine.engine.device_config.device.type) == "cuda": | ||
| logger.info(memory_summary(engine.engine.device_config.device)) | ||
| else: | ||
| logger.warning("Cannot print device usage for device type: %s", device_type) |
There was a problem hiding this comment.
We cannot print the memory summary anymore, as this method is not available from the engine client.
maxdebayser
reviewed
Aug 6, 2024
dtrifiro
force-pushed
the
get-rid-of-upstream-code
branch
2 times, most recently
from
8477d51
to
46ae710
Compare
dtrifiro
force-pushed
the
get-rid-of-upstream-code
branch
from
dd583dc
to
7cb6234
Compare
|
Parametrization is disabled because of this error |
This was referenced Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adaptations for vLLM==0.5.4