Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add platform for derived as folder part #299

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

add platform for derived as folder part #299

wants to merge 11 commits into from

Conversation

pindge
Copy link
Contributor

@pindge pindge commented Mar 28, 2023 •
edited
Loading

Fixes: #298

addes platform abbrev to end of the dataset folder path if its c3 derivative product.

@pindge pindge marked this pull request as ready for review March 28, 2023 05:45
@pindge pindge changed the title add platform for derived add platform for derived as folder part Mar 28, 2023
@pindge pindge requested a review from jeremyh March 28, 2023 05:45
@codecov
Copy link

codecov bot commented Mar 28, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (17f80b6) 84.77% compared to head (9efe2c3) 84.78%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #299      +/-   ##
===========================================
+ Coverage    84.77%   84.78%   +0.01%     
===========================================
  Files           26       26              
  Lines         4408     4411       +3     
===========================================
+ Hits          3737     3740       +3     
  Misses         671      671
Impacted Files Coverage Δ
eodatasets3/names.py 95.26% <100.00%> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jeremyh
Copy link
Collaborator

jeremyh commented Mar 29, 2023

As is discussed on Teams, the approval for this as a change is going through other channels, as eo-datasets is just following the upstream "naming conventions" documents that were made.

If it is approved, though, we should probably make this a different naming_conventions="blah" variant, rather than modfiying the existing one and breaking backwards compatibility. Products can then choose the move to the new one rather than have datasets start appearing in unexpected places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyh jeremyh Awaiting requested review from jeremyh

@omad omad Awaiting requested review from omad

@emmaai emmaai Awaiting requested review from emmaai

@SpacemanPaul SpacemanPaul Awaiting requested review from SpacemanPaul

@jmettes jmettes Awaiting requested review from jmettes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

destination_folder only supports baseline products and not derived products
2 participants
@pindge @jeremyh