Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should PSU monitor be requesting and releasing GPIO on every read? #7

Open
bjwyman opened this issue Jul 26, 2021 · 2 comments
Open

Comments

@bjwyman
Copy link
Contributor

bjwyman commented Jul 26, 2021

During a review to remove some excessive tracing, it was pointed out that the new power supply monitor is requesting and releasing the GPIO line on every "poll".

It is not 100% clear if this is good or bad behavior.

Should the release of the line be removed?

https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-power/+/44977/1/phosphor-power-supply/util.cpp#48

@mdmillerii
Copy link

@amboar FYI

@amboar
Copy link
Member

amboar commented Aug 3, 2021

I don't have much of an opinion. It's not terribly different to open/read/close of the sysfs attribute. Do whatever is less of a headache in the code unless we're having performance issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants