Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A issue about "Get Time Difference" in test_ipmi_sel_time.robot #2246

Open
Julia-Delta opened this issue Jul 22, 2024 · 3 comments
Open

A issue about "Get Time Difference" in test_ipmi_sel_time.robot #2246

Julia-Delta opened this issue Jul 22, 2024 · 3 comments

Comments

@Julia-Delta
Copy link

Julia-Delta commented Jul 22, 2024

When I test ipmi sel time items, I got value -1 about the difference between BMC time and SEL time.
I found that the parameter order seems wrong.
In line 134, line 285 and line 337, the diff time was get_sel_time minus bmc_time.
But bmc_time was the newest time, so the diff time maybe negative number.
I think that the condition need to modify and change "${difference}= Get Time Difference ${get_sel_time} ${bmc_time}" to "${difference}= Get Time Difference ${bmc_time} ${get_sel_time}"

@gkeishin
Copy link
Member

@Ganesan149 @KothaiSrini or @Alagiridhilipank can u guys take a look and respond to this ?

@gkeishin
Copy link
Member

or @KManimozhi123

@Ganesan149
Copy link
Contributor

@Julia-Delta @gkeishin

yes, this requires code change.
In line 134, line 158, line 285 and line 337 these 4 lines the changes needs to be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants