Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redfish/v1/Systems/system contains link only to the first chassis from the chassis collection #225

Open
Kostr opened this issue Sep 15, 2021 · 9 comments
Labels
bug Something isn't working

Comments

@Kostr
Copy link
Contributor

Kostr commented Sep 15, 2021

redfish/v1/Systems/system contains link only to the first chassis from the chassis collection.

Example: there are 3 chassis under redfish/v1/Chassis:

{
    "@odata.id": "/redfish/v1/Chassis",
    "@odata.type": "#ChassisCollection.ChassisCollection",
    "Members": [
        {
            "@odata.id": "/redfish/v1/Chassis/AMD_EthanolX_Baseboard"
        },
        {
            "@odata.id": "/redfish/v1/Chassis/SP3_Baseboard"
        },
        {
           "@odata.id": "/redfish/v1/Chassis/AMD_EthanolX_Chassis"
        }
    ],
    "[email protected]": 3,
    "Name": "Chassis Collection"
}

But redfish/v1/Systems/system contains link only to the first one:

"Links": {
    "Chassis": [
        {
            "@odata.id": "/redfish/v1/Chassis/AMD_EthanolX_Baseboard"
        }
    ],
    "ManagedBy": [
        {
            "@odata.id": "/redfish/v1/Managers/bmc"
        }
    ]
},

Relevant links to the code that is responsible for this behaviour:
https://github.com/openbmc/bmcweb/blob/master/redfish-core/lib/systems.hpp#L2748

std::string chassisId = subtree[0].first.substr(idPos + 1);

@gtmills gtmills added the bug Something isn't working label Sep 27, 2021
@sandeepiot
Copy link

sandeepiot commented Apr 4, 2022

Hi Guys,

Can Someone please assign this ticket to my name ? We are trying to contribute to the openBmc community. Please do let us know the process/steps as well.

Thanks,
Sandeep.

@edtanous
Copy link
Contributor

edtanous commented Apr 5, 2022

Feel free to work on it; We generally don't use the assigned field in github. Our development process is documented in the openbmc/docs repository, and the local bmcweb advice is documented in DEVELOPING.md in this repo.

Looking forward to seeing the patch.

@sandeepiot
Copy link

Hi @edtanous,

Thanks for the information. Could you please let us know how to reproduce this issue ? I am running it on QEMU and not finding a way to reproduce this. So is there a way to simulate it on QEMU. Please do let us know. This would help us to test the patch as well.

Thanks,
Sandeep.

@edtanous
Copy link
Contributor

edtanous commented Apr 6, 2022

Hi @edtanous,

Thanks for the information. Could you please let us know how to reproduce this issue ? I am running it on QEMU and not finding a way to reproduce this. So is there a way to simulate it on QEMU. Please do let us know. This would help us to test the patch as well.

Thanks, Sandeep.

Given that qemu has no chassis, you're not going to be able to reproduce it there. You'll likely need to get on a real system, and the first description shows how to reproduce it.

@Anjaliintel-21
Copy link
Contributor

Whether anyone is still working on this issue?

@chaul-ampere
Copy link
Contributor

chaul-ampere commented Feb 7, 2023

Hi, is there anyone still working on this issue? I'm about to submit a patch and wonder if there is an ongoing duplication.

@amboar
Copy link
Member

amboar commented Feb 7, 2023

s/ongoing duplication/opportunity for collaboration/ ;)

@chaul-ampere
Copy link
Contributor

s/ongoing duplication/opportunity for collaboration/ ;)

Sure

@gtmills
Copy link
Member

gtmills commented Mar 5, 2024

Still a problem.
https://github.com/openbmc/bmcweb/blob/master/redfish-core/lib/redfish_util.hpp#L63

Need an association or something to look at here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants