Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help wanted: add size-limit check in CI #1853

Open
drwpow opened this issue Aug 14, 2024 · 0 comments
Open

Help wanted: add size-limit check in CI #1853

drwpow opened this issue Aug 14, 2024 · 0 comments
Labels
good first issue Straightforward problem, solvable for first-time contributors without deep knowledge of the project openapi-fetch Relevant to the openapi-fetch library PRs welcome PRs are welcome to solve this issue!

Comments

@drwpow
Copy link
Contributor

drwpow commented Aug 14, 2024

openapi-fetch as it’s grown in features has grown in size! It was originally 2 kb when it started out, but with middleware support and other features is now closer to 6 kb (technically 5.8 kb but who’s counting?—wait we need to!).

Adding something like Size Limit (or something else) in CI to make sure the bundle size doesn’t increase would be helpful. The goal of this check isn’t to prevent any features or bugfixes if they add to the weight at all, rather, it just helps prevent unintentional size increases. We can always decide to increase the package weight if it provides value for the weight.

@drwpow drwpow added PRs welcome PRs are welcome to solve this issue! good first issue Straightforward problem, solvable for first-time contributors without deep knowledge of the project openapi-fetch Relevant to the openapi-fetch library labels Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Straightforward problem, solvable for first-time contributors without deep knowledge of the project openapi-fetch Relevant to the openapi-fetch library PRs welcome PRs are welcome to solve this issue!
Projects
None yet
Development

No branches or pull requests

1 participant