Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break _custom.scss into different files #92

Open
botraunak opened this issue Mar 14, 2018 · 3 comments
Open

Break _custom.scss into different files #92

botraunak opened this issue Mar 14, 2018 · 3 comments
Labels
GSoC Google summer of code issues

Comments

@botraunak
Copy link
Collaborator

Refactor the page specific styles into different sass files
@botraunak botraunak added the GSoC Google summer of code issues label Mar 14, 2018
@jorigelbaugh
Copy link

jorigelbaugh commented Mar 18, 2019 •
edited
Loading

I would like to work on this issue!

@ankit01ojha
Copy link
Collaborator

@jorigelbaugh sure, go ahead.

@jorigelbaugh
Copy link

Great! I updated the name of "_common" to "_general_styles"; essentially this file now contains styling that applies to more than one page/file. All other sections of this original file were refactored into separate files, according to either page or function (for example, all styles for the account_list page are now in a file named "_account_list.scss"; all styles related to status colors are now in a file named "_status_colors.scss").

jorigelbaugh pushed a commit to jorigelbaugh/web-self-service-app that referenced this issue Mar 21, 2019
Fix openMF#92 - split _custom.scss into different files, renaming _cu…
77c5ca3 
…stom.scss to _general_styles.scss
@jorigelbaugh jorigelbaugh mentioned this issue Mar 21, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
GSoC Google summer of code issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@botraunak @ankit01ojha @jorigelbaugh