Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The provenance is not always properly reported #338

Open
lquerel opened this issue Aug 22, 2024 · 0 comments
Open

The provenance is not always properly reported #338

lquerel opened this issue Aug 22, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@lquerel
Copy link
Contributor

lquerel commented Aug 22, 2024

The provenance information reported by Weaver is not always ideal. Below are a few examples that should be improved:

Instead of:

Provenance: https://github.com/open-telemetry/semantic-conventions/archive/refs/tags/v1.27.0.zip[model]/metrics/go-metrics.yaml

We should have:

Provenance: https://github.com/open-telemetry/semantic-conventions/archive/refs/tags/v1.27.0.zip[model/metrics/go-metrics.yaml]

Instead of:

  ⚠ The attribute `aws.dynamodb.table_names` in the group `registry.aws.dynamodb` contains an example that will be considered invalid in the future. All examples SHOULD be of type `string[]`.
  │ Provenance: "/Users/L.Querel/.weaver/semconv_registry_cache/repo.EcPezALMZfx2/registry/aws.yaml"

We should have:

  ⚠ The attribute `aws.dynamodb.table_names` in the group `registry.aws.dynamodb` contains an example that will be considered invalid in the future. All examples SHOULD be of type `string[]`.
  │ Provenance: https://github.com/open-telemetry/semantic-conventions/archive/refs/tags/v1.27.0.zip[model/registry/aws.yaml]

Implementation recommendation: In weaver_cache we should extend RegistryPath to add a method updating the current path with a relative path.

@lquerel lquerel added the enhancement New feature or request label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

1 participant