-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question about OTEL_SEMCONV_STABILITY_OPT_IN
#240
Comments
I would see it as an invalid value, log an warning maybe and fallback to the default behavior. We should probably document this if we decide to go this route. |
Maybe we could change the values to something like |
This is how we implemented that in the Java instrumentation -- I chose to just sum up the boolean values and enable everything. Even if this is technically invalid value, I think this is probably a bit gentler to the user who just wanted both options and typed all the settings. |
I don't have a strong preference, but I think @mateuszrzeszutek approach is the most user friendly. I fully agree with @joaopgrassi that this should be added to the documentation. |
I'm working on Semantic Conventions for Http which defines the Environment Variable
OTEL_SEMCONV_STABILITY_OPT_IN
as a list of comma-separated values.How should I handle if multiple values have been set?
For example:
What's the expected behavior?
The text was updated successfully, but these errors were encountered: