Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FaaS metrics - Should we capture metrics for clients invoking functions? #235

Open
joaopgrassi opened this issue Aug 7, 2023 · 1 comment
Assignees

Comments

@joaopgrassi
Copy link
Member

In #88 (comment) we discussed and aligned that all existing FaaS metrics are related to the FaaS itself and not by whoever is invoking them (clients).

So, the conventions were modified to only include metrics related to the FaaS itself, and not by clients invoking them.

We need to discuss if:

  • We want/need to record metrics that measure things related to clients invoking a function (how long it took, how many errors etc)
    • If so, we should decide how to name them. A proposal was to introduce them under a new namespace faas.client.*
  • We don't need them and are fine with only the "faas-side" metrics only
@jviau
Copy link

jviau commented Feb 7, 2024

This would not apply to Azure functions as there is not concept of a FaaS client. All calls to Azure Functions are done through existing clients: http, messaging, etc. Do other FaaS implementations have a specific client? Do we have a common enough understanding of what a FaaS client is to make this part of the core spec?

As we are talking about naming these with a scheme of faas.client.*, should we also name the non-client spans with a differentiator as well? faas.server.*, faas.host.*, or faas.worker.*? Or something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants