-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add User-agent OS attributes #1434
base: main
Are you sure you want to change the base?
Conversation
The PR is mostly a copy and paste from the OS attributes current definition to the user_agent's attributes, is there a way to reference them but applying the "user_agent" prefix? |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
||
## User-agent OS Attributes | ||
|
||
Describes the OS user-agent attributes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please describe the use-case for these attributes? is there any instrumentation or semantic convention that's supposed to populate it?
We usually add attributes along with the convention (span/metric/resource/event) that uses them - this usually results in more specific attribute definition and more clarity for those who want to populate the attribute on other conventions.
So, could we define such convention and/or document the use-case in some other way?
Fixes #1433
Changes
Please provide a brief description of the changes here.
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
[chore]