Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove system.device attribute in favor of device.id #1432

Open
rogercoll opened this issue Sep 26, 2024 · 0 comments
Open

Remove system.device attribute in favor of device.id #1432

rogercoll opened this issue Sep 26, 2024 · 0 comments
Assignees
@arminru
Labels
area:system enhancement New feature or request experts needed This issue or pull request is outside an area where general approvers feel they can approve system-semconv-wg-ga-blocker triage:needs-triage

Comments

@rogercoll
Copy link
Contributor

Area(s)

area:system

Is your change request related to a problem? Please describe.

It looks like system.device and device.id are duplicated attributes: https://github.com/open-telemetry/semantic-conventions/blob/main/docs/resource/device.md

Describe the solution you'd like

Single attribute to reference the same object: device.id looks more descriptive

Describe alternatives you've considered

No response

Additional context

#1408 (comment)
@rogercoll rogercoll added enhancement New feature or request experts needed This issue or pull request is outside an area where general approvers feel they can approve triage:needs-triage labels Sep 26, 2024
@rogercoll rogercoll mentioned this issue Sep 26, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arminru arminru

Labels
area:system enhancement New feature or request experts needed This issue or pull request is outside an area where general approvers feel they can approve system-semconv-wg-ga-blocker triage:needs-triage
Projects
System Semantic Convention Working Group
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mx-psi @arminru @rogercoll