Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Simple/Batch processor to concurrently invoke Exporter.Export() #4231

Open
cijothomas opened this issue Sep 26, 2024 · 0 comments
Open
Labels
spec:logs Related to the specification/logs directory

Comments

@cijothomas
Copy link
Member

What are you trying to achieve?

Current spec restricts Simple/Batch processors from calling exporter.export() concurrently. This can be limiting in some scenarios:

  1. When Exporting to Windows ETW, Linux user_events etc., the exporters can handle concurrent calls. This is important to get highest performance. These exporters are to be paired with SimpleProcessor, as they cannot afford to have the contention that is typical in the BatchProcessors. However, without SimpleProcessor concurretly calling export(), we wont get the required perf due to contention introduced to syncronize export() calls.
  2.  Various discussions in Clarify spans export concurrency #4205 shows the need for concurrently calling export() from BatchProcessors as well.

In short, there is need for allowing both Simple,Batch processors to call export() concurrently.

To keep back-compatibility, we can do something like:

  1. Allow exporters to advertise if their export() methods are okay to be called concurrently. If no explicit advertisement, then default to false.
  2. Relax restriction in exporting processors (Simple/Batch), to call export() concurrently, if the paired exporter has advertised that they support being called concurrently.
  3. Spec can be silent on "how" exporters advertise this, and leave it for implementations.

Additional context.

Previous attempt to make this happen, but only for SimpleProcessor: #4163

Opened for Logs, but equally applicable for Tracing too.

@cijothomas cijothomas added the spec:logs Related to the specification/logs directory label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:logs Related to the specification/logs directory
Projects
None yet
Development

No branches or pull requests

1 participant