Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics API - Move to builder pattern for creating Meters #2164

Open
cijothomas opened this issue Oct 2, 2024 · 2 comments
Open

Metrics API - Move to builder pattern for creating Meters #2164

cijothomas opened this issue Oct 2, 2024 · 2 comments
Milestone

Comments

@cijothomas
Copy link
Member

Related to #1527, but for Metrics
This is part of Metrics API, and hence must be done by Metrics API RC.

@cijothomas cijothomas added this to the 0.27 milestone Oct 2, 2024
@stormshield-fabs
Copy link
Contributor

This was made a bit more complicated with the object-safety requirement on MeterProvider added in #2112

The problem is mostly about ergonomics because we probably can't have an API similar to the other signals.

I don't think we want to re-introduce ObjectSafeMeterProvider, since we would not be able to forward the builder method anyway, but a solution could be to have a "standalone" MeterBuilder (without the MeterProvider::meter_builder method).

@cijothomas
Copy link
Member Author

@utpilla can you help with this?

ALso https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry/src/common.rs#L413 is something we want to remove from opentelemetry crate. (okay to be in sdk crate)

@utpilla utpilla changed the title Metris API - Move to builder pattern for creating Meters Metrics API - Move to builder pattern for creating Meters Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants