From 2854936bc33547c256f6f0d19d32463c11bff8e2 Mon Sep 17 00:00:00 2001 From: xuan-cao-swi Date: Sun, 15 Sep 2024 15:41:12 -0400 Subject: [PATCH] fix: add warning if invalid meter name given --- metrics_sdk/lib/opentelemetry/sdk/metrics/meter_provider.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/metrics_sdk/lib/opentelemetry/sdk/metrics/meter_provider.rb b/metrics_sdk/lib/opentelemetry/sdk/metrics/meter_provider.rb index 205ff5db0d..1ba5d5f335 100644 --- a/metrics_sdk/lib/opentelemetry/sdk/metrics/meter_provider.rb +++ b/metrics_sdk/lib/opentelemetry/sdk/metrics/meter_provider.rb @@ -36,6 +36,7 @@ def meter(name, version: nil) OpenTelemetry.logger.warn 'calling MeterProvider#meter after shutdown, a noop meter will be returned.' OpenTelemetry::Metrics::Meter.new else + OpenTelemetry.logger.warn "Invalid meter name provided: #{name.nil? ? 'nil' : 'empty'} value" if name.to_s.empty? @mutex.synchronize { @meter_registry[Key.new(name, version)] ||= Meter.new(name, version, self) } end end