Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elasticsearch picks up the body info #5380

Closed
chenkaiyin1201 opened this issue Feb 15, 2022 · 3 comments
Closed

Elasticsearch picks up the body info #5380

chenkaiyin1201 opened this issue Feb 15, 2022 · 3 comments
Labels
enhancement New feature or request needs author feedback Waiting for additional feedback from the author stale

Comments

@chenkaiyin1201
Copy link

ot-plugin:io.opentelemetry.elasticsearch-rest-7.0
es-sdk:Java Low Level REST Client

The elasticsearch-sdk search method is a POST request, OT don`t support obtaining search-body info. Have you considered supporting get this info.

Thanks.

@chenkaiyin1201 chenkaiyin1201 added the enhancement New feature or request label Feb 15, 2022
@trask
Copy link
Member

trask commented Aug 15, 2023

related: open-telemetry/oteps#234

@trask
Copy link
Member

trask commented Aug 26, 2023

related to #8778

I think it would make sense to focus on establishing convention and prototype for #8778

Since elasticsearch uses an http client under the hood, it would then be possible to capture the http body on the underlying http client span after #8778 is implemented

@chenkaiyin1201 let us know if this makes sense, and we can close this issue, thx

@trask trask added the needs author feedback Waiting for additional feedback from the author label Aug 26, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2023

This has been automatically marked as stale because it has been marked as needing author feedback and has not had any activity for 7 days. It will be closed automatically if there is no response from the author within 7 additional days from this comment.

@github-actions github-actions bot added the stale label Sep 2, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs author feedback Waiting for additional feedback from the author stale
Projects
None yet
Development

No branches or pull requests

2 participants