Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add config property to set trace level #247

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add config property to set trace level #247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,17 @@
],
"default": "opa-fmt",
"description": "The formatter to use for Rego. Supports: ['opa-fmt', 'opa-fmt-rego-v1', 'regal-fix']."
},
"regal.trace.server": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks positive, I think it looks too like we might be able to replace

vscode-opa/src/ls/clients/regal.ts

Line 120 in bc2404b

if (process.env.VSCODE_DEBUG_MODE === 'true') {
with this - but only once we have the Regal LS side to this too?

Do we not need to send/set this config as part of the initialisation options too? (i.e. in here somewhere: https://github.com/open-policy-agent/vscode-opa/blob/main/src/ls/clients/regal.ts#L167)

"scope": "window",
"type": "string",
"enum": [
"off",
"messages",
"verbose"
],
"default": "off",
"description": "Traces the communication between VS Code and the Regal language server."
}
}
},
Expand Down
Loading