From 200942f28e56036b25a4429e627f42b7a4d372a1 Mon Sep 17 00:00:00 2001
From: Janno Kusman <janno.kusman@cyber.ee>
Date: Wed, 18 Sep 2024 09:58:12 +0300
Subject: [PATCH] RM-3342: load test results recommendations

---
 admin-guide.md     | 16 ++++++++++++++++
 get-server/pom.xml |  4 +++-
 put-server/pom.xml |  2 +-
 3 files changed, 20 insertions(+), 2 deletions(-)

diff --git a/admin-guide.md b/admin-guide.md
index b090650..b807fa6 100644
--- a/admin-guide.md
+++ b/admin-guide.md
@@ -111,6 +111,19 @@ To run the server, execute the following command:
 java -jar -Dspring.config.location=application.properties cdoc2-put-server-VER.jar
 `
 
+#### Running in Docker
+
+From `1.4.1` release docker images are using `Java 21` as Java base image. To fully use Java21 improvements
+enable virtual threads by adding `spring.threads.virtual.enabled=true` into `application.properties`.
+
+To get better throughput it's recommended to give at least 2 CPUs and 1GB of memory per `get-server` and `put-server` instance.
+2 GB of memory per process is even better (some additional throughput gains).
+
+Instead of creating two VMs with 1CPU, create single VM with 2 CPU and run both
+`get-server` and `put-server` on that VM instance (two Java process per VM).
+
+For sample setup see [cdoc2-gatling-tests/setup-load-testing](https://github.com/open-eid/cdoc2-gatling-tests/tree/master/setup-load-testing)
+
 ### Get Server
 
 #### Requirements
@@ -140,6 +153,9 @@ This will configure the Get Server to trust all requests done by Estonian ID car
 The configuration file `application.properties` must contain the following configuration parameters:
 
 ```
+#Enable when running on Java21 to improve througput by ~20%
+#spring.threads.virtual.enabled=true
+
 # The format used for the keystore. It could be set to JKS in case it is a JKS file
 server.ssl.key-store-type=PKCS12
 
diff --git a/get-server/pom.xml b/get-server/pom.xml
index 82a8c39..dd63a29 100644
--- a/get-server/pom.xml
+++ b/get-server/pom.xml
@@ -415,7 +415,9 @@
 				<configuration>
 					<image>
 						<env>
-							<BP_JVM_VERSION>${java.version}</BP_JVM_VERSION>
+							<!-- use  spring.threads.virtual.enabled=true in application.properties -->
+							<!-- to take advantage of Java 21 virtual threads -->
+							<BP_JVM_VERSION>21</BP_JVM_VERSION>
 							<BP_SPRING_CLOUD_BINDINGS_DISABLED>true</BP_SPRING_CLOUD_BINDINGS_DISABLED>
 							<!--suppress UnresolvedMavenProperty -->
 							<BP_DEPENDENCY_MIRROR>${bp.dependency.mirror}</BP_DEPENDENCY_MIRROR>
diff --git a/put-server/pom.xml b/put-server/pom.xml
index 1fa63cf..813c7fc 100644
--- a/put-server/pom.xml
+++ b/put-server/pom.xml
@@ -414,7 +414,7 @@
 				<configuration>
 					<image>
 						<env>
-							<BP_JVM_VERSION>${java.version}</BP_JVM_VERSION>
+							<BP_JVM_VERSION>21</BP_JVM_VERSION>
 							<BP_SPRING_CLOUD_BINDINGS_DISABLED>true</BP_SPRING_CLOUD_BINDINGS_DISABLED>
 							<!--suppress UnresolvedMavenProperty -->
 							<BP_DEPENDENCY_MIRROR>${bp.dependency.mirror}</BP_DEPENDENCY_MIRROR>