Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Protobuf to v21.12 #2626

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Update Protobuf to v21.12 #2626

merged 3 commits into from
Nov 16, 2023

Conversation

hamptonm1
Copy link
Collaborator

@hamptonm1 hamptonm1 commented Nov 15, 2023

Upgrading Protobuf to match the onnx community. In order to upgrade Protobuf we have to include the abseil dependencies as well or else we will receive failures. I am hoping by upgrading Protobuf it will help us with ONNX 1.15.0 upgrade.

@hamptonm1 hamptonm1 self-assigned this Nov 15, 2023
@hamptonm1 hamptonm1 marked this pull request as ready for review November 15, 2023 23:39
@hamptonm1 hamptonm1 requested review from gongsu832 and removed request for tungld November 15, 2023 23:39
CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Collaborator

@gongsu832 gongsu832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hamptonm1 hamptonm1 merged commit 7732fec into onnx:main Nov 16, 2023
8 checks passed
@hamptonm1 hamptonm1 deleted the hamptonm/feature/protobuf-21.12 branch November 16, 2023 18:14
@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #13475 [push] Update Protobuf to v21.1... started at 13:15

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #12469 [push] Update Protobuf to v21.1... started at 13:24

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #13448 [push] Update Protobuf to v21.1... started at 12:15

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #13448 [push] Update Protobuf to v21.1... passed after 2 hr 37 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #13475 [push] Update Protobuf to v21.1... aborted after 3 hr 17 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #12469 [push] Update Protobuf to v21.1... aborted after 3 hr 17 min

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants