-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NNPA] A rewrite pattern to get dim directly from a zTensor without unstickification. #2624
Conversation
Signed-off-by: Tung D. Le <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, makes total sense
Jenkins Linux amd64 Build #13521 [push] Get dim directly from zT... started at 20:54 |
Jenkins Linux s390x Build #13548 [push] Get dim directly from zT... started at 21:54 |
Jenkins Linux ppc64le Build #12545 [push] Get dim directly from zT... started at 22:00 |
Jenkins Linux amd64 Build #13521 [push] Get dim directly from zT... failed after 58 min |
Jenkins Linux s390x Build #13548 [push] Get dim directly from zT... passed after 1 hr 20 min |
Jenkins Linux ppc64le Build #12545 [push] Get dim directly from zT... passed after 1 hr 57 min |
This patch is to add a rewriting pattern that removes
zhigh.unstick
when getting dimensions.For example, the following code
will be replace by
where the dimension is obtained directly from a zTensor without unstickifying the zTensor.