Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option to translate Fastlane (app store details) in Weblate #127

Closed
lucasmz-dev opened this issue Apr 20, 2024 · 12 comments
Closed

Comments

@lucasmz-dev
Copy link
Contributor

No description provided.

@lucasmz-dev lucasmz-dev changed the title Add translation for fastlane metadata on Weblate Add translation of fastlane metadata on Weblate Apr 20, 2024
@yurtpage
Copy link

👍 This very important because the F-Droid doesn't make an auto translation and non English speakers can't understand what the app is doing.

Here is a sample of Conversations app metadata translation via Weblate https://translate.codeberg.org/projects/conversations/app-store-metadata-conversations/

@lucasmz-dev
Copy link
Contributor Author

because the F-Droid doesn't make an auto translation

Thankfully! I would be pretty sad if they did that to be honest; machine translation or bad translations makes things less accessible than just keeping it in the native language or English.

Right now, I can open a PR to add some metadata, and I suppose it would work, but it's very manual and I wouldn't be notified of changes and updates to the original string as what I can do with Weblate.

@lucasmz-dev
Copy link
Contributor Author

After doing what I said above, I realize it's a bit more complicated, still I feel like it's possible to have at least the short and full description, and maybe title if that makes sense.

OnionShare has some graphics and images which are hard to translate; not sure if there's files to be able to do that or something. See #128.

@yurtpage
Copy link

Even without images i18n it would be really useful.

@grote
Copy link
Collaborator

grote commented Apr 23, 2024

upstream source files seem to be here: https://codeberg.org/iNPUTmice/Conversations/src/branch/master/src/conversations/fastlane/metadata/android/en-US

We would need to check how to include this in weblate the same way. Maybe @emmapeel2 knows.

@lucasmz-dev lucasmz-dev changed the title Add translation of fastlane metadata on Weblate Add the option to translate Fastlane (app store details) in Weblate Apr 25, 2024
@yurtpage
Copy link

Here more details about translation for the full_description.txt WeblateOrg/weblate#1525 (comment)

@emmapeel2
Copy link
Contributor

upstream source files seem to be here: https://codeberg.org/iNPUTmice/Conversations/src/branch/master/src/conversations/fastlane/metadata/android/en-US

To add to weblate is easy: you need to create this folder structure in a repository, and we can hook it up to a new weblate component. I can do that under the OnionShare weblate project.

What I don´t know is where do you tell Fastlane to pick up the translations.

@lucasmz-dev
Copy link
Contributor Author

I thought Fastlane just picked it up automatically?

@emmapeel2
Copy link
Contributor

Oooooh, I see, the files are already in the repo (duh! I didn´t looked). I will add it to weblate, linked to the other components.

@emmapeel2
Copy link
Contributor

OK, I have added the component to weblate, you can translate the metadata here: https://hosted.weblate.org/projects/onionshare/android-metadata/

It was very easy with weblate already supporting the format, and it is only one component instead of 4 little one-string components.

@grote grote closed this as completed May 6, 2024
@lucasmz-dev
Copy link
Contributor Author

Just in case, PT-BR translations are not yet showing up, I believe an app update (or something) triggers that.

@emmapeel2
Copy link
Contributor

I guess new releases will provide the translations. Weblate is already submitting them to the repository: https://github.com/onionshare/onionshare-android/pull/126/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants