Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default connection configuration #2

Open
josegrobles opened this issue Mar 20, 2019 · 1 comment
Open

Default connection configuration #2

josegrobles opened this issue Mar 20, 2019 · 1 comment
Assignees
Labels
help wanted Extra attention is needed suggestion

Comments

@josegrobles
Copy link
Contributor

Currently you need to specify explicitly the connection key for the configuration, in my opinion it should not be mandatory and it should default to the AZURE_SERVICEBUS_CONNECTION_STRING environment variable

@feliun
Copy link
Collaborator

feliun commented Apr 23, 2019

@josegrobles generally I prefer configuration to be agnostic of the implementation. Azure relies on process.env, which is not a great practice IMO. I prefer to abstract that away and leave the client hardcode the string, or provide the process.env:

connectionString: "whateverIlike" || process.env. AZURE_SERVICEBUS_CONNECTION_STRING

@UlisesGascon UlisesGascon added the help wanted Extra attention is needed label Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed suggestion
Projects
None yet
Development

No branches or pull requests

3 participants