Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong ordering in records returned by records() iterator #237

Open
valerino opened this issue Jul 2, 2023 · 1 comment
Open

wrong ordering in records returned by records() iterator #237

valerino opened this issue Jul 2, 2023 · 1 comment

Comments

@valerino
Copy link

valerino commented Jul 2, 2023

hi, i think there is a bug in event parsing regarding ordering.
the records() iterator return records appended in this way:

chunk0: record10,record9,record8,record7,record6,record5,record4,record3,record2,record1
chunk1: record20,record19,record18,record17,record16,record15,record14,record13,record12,record11
and so on ...

basically, each chunk is orderered in a descending way, and this leads to the records not being in the original order when pulled from the iterator. and this may break some utilization of your lib where the original order needs to be preserved.

@valerino valerino closed this as completed Jul 2, 2023
@valerino valerino reopened this Jul 2, 2023
@valerino
Copy link
Author

valerino commented Jul 2, 2023

closing and reopened in pyevtx-rs repo: omerbenamram/pyevtx-rs#25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant