Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Github tokens instead of ssh keys #49

Open
manics opened this issue Jul 31, 2016 · 2 comments
Open

Use Github tokens instead of ssh keys #49

manics opened this issue Jul 31, 2016 · 2 comments

Comments

@manics
Copy link
Member

manics commented Jul 31, 2016

If this works it'd be possible to supply the username and token as an environment variable instead of messing with ssh keys. It's also easy to revoke tokens if necessary.

@sbesson
Copy link
Member

sbesson commented Aug 1, 2016

@manics: I completely agree that the token-based HTTPS URL are very attractive and managing only tokens as opposed to tokens + SSH keys would be very advantageous. For instance, I use a development token for testing/pushing tags to @snoopycrimecop manually to prevent interfering with my own SSH keys.

The main downside/amount of work I see with this proposal is that the scc library was been written with the SSH URLs in mind. This would need to be updated to support token-based approach. Additionally, we would need to review all places where a token might be leaked publicly via the remote URL.

@manics
Copy link
Member Author

manics commented Aug 1, 2016

Additionally, we would need to review all places where a token might be leaked publicly via the remote URL.

My reading of the git-credentials links is that the token can be read automatically from a file store, and doesn't need to be included in the HTTPS URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants