-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small fixes to match with the GF specs #2
Comments
Hello @emmamarichal, I am back on track with this! A few comments:
To maintain the style, it’s critical that the dots fit into the 6x10 grid. Here are three options, each with its own drawbacks:
|
Hi @oliverlalan, We think it's indeed better to keep an actual monospace.
Let me know what you think about that :) |
Hello @emmamarichal, I would discard the "double" width option for two reasons: First, the problematic glyphs would look way too spaced. And second, and most important, the font would not be technically "monospaced" anymore (I am not a font engineer, but I am quite sure fontbakery checks all glyphs have the same width when the font tables are flagged as monospace). I would go with the redesign and exceptions alternative. Here it is my proposal:
If you are ok with it, confirm it, and I will update the characters marked with green and yellow, left the red ones as they are, and let you know when all the other issues are closed. Regards! |
Hi @oliverlalan! I'm ok with that, you can go ahead :) Let me know once it's ready to review and onboard! |
Hello @emmamarichal ! The font has been updated with all the requested changes (repository and issue renaming included). You can already fork and do the font QA. Just let me know if there is anything else you need from my side. Regards! |
Excellent, thanks a lot, I'll take a look asap :) |
Hi @oliverlalan!
Again, congrats and thank you for this amazing project! I took a look at the files, and all is almost perfect.
A few things to update:
Don't hesitate if you have any questions :)
Cheers!
Example of caron:
The text was updated successfully, but these errors were encountered: