Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type guessing a column of zeros (0) fails with exception #175

Open
samhatchett opened this issue May 3, 2017 · 0 comments
Open

type guessing a column of zeros (0) fails with exception #175

samhatchett opened this issue May 3, 2017 · 0 comments

Comments

@samhatchett
Copy link
Contributor

due to this line:
https://github.com/okfn/messytables/blob/master/messytables/types.py#L291

... if not cell.value evaluates to true when cell.value === 0 and so no guesses are stored for that column. Which means that the guess list is empty and that causes an exception later on.

I see that this whole code chunk is removed in other branches and the project seems to be in a kind of flux, so not sure if this is already fixed and just waiting to be merged/released, but thought it worth documenting here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant