Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON Table Schema in MessyTables #135

Closed
pwalsh opened this issue Jun 22, 2015 · 3 comments
Closed

JSON Table Schema in MessyTables #135

pwalsh opened this issue Jun 22, 2015 · 3 comments

Comments

@pwalsh
Copy link
Member

pwalsh commented Jun 22, 2015

In light of mk270/json-table-schema-python#4 and #131, I want to talk about about JSON Table Schema.

  • We recently wrote a new JSON Table Schema library: https://github.com/okfn/jsontableschema-py
    • It is much more in line with the JSON Table Schema spec
    • It is used in a number of projects, and is therefore guaranteed to keep under development
    • It is currently published on PyPI under jtskit
  • A couple of weeks ago, I took over the package for json-table-schema on PyPI from @mk270
  • The plan is, in the next couple of weeks, to start publishing "jtskit" under the json-table-schema package
@davidread
Copy link
Collaborator

davidread commented Nov 4, 2015

The question is, is there a reasonable chance of breaking changes affecting messytables? If so we should add an upper-limit on the json-table-schema version in setup.py, for the sake of future messytables releases.

@pwalsh
Copy link
Member Author

pwalsh commented Nov 4, 2015

@davidread there should be an upper-limit on json-table-schema in any event (and other deps., as I made the case for in #144).

For your question, in this case: yes, the new code is a completely different API.

I think the question is more, then, does anyone want to fix JTS support in the current version of messy tables? if yes, the effort should be made to support the new lib, which actually implements most of the spec, unlike the current dependency in messytables. If it is not important, then, I strongly suggest pinning the dependency at the last version of the old codebase.

I've been talking with @pudo about MT2 (ref. and ref.) and any code there would certainly use the new lib in any event.

@pwalsh
Copy link
Member Author

pwalsh commented Jul 23, 2016

Version has been pinned to the (very) old jts lib. We'd have to see more interest to make the changes required for the more up-to-date lib that OKI has. And, once @pudo brings in typecast it will probably be enough for the current use cases around messytables.

@pwalsh pwalsh closed this as completed Jul 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants