Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Picture viewer #2347

Open
taoeffect opened this issue Sep 13, 2024 · 2 comments · May be fixed by #2367
Open

Picture viewer #2347

taoeffect opened this issue Sep 13, 2024 · 2 comments · May be fixed by #2367
Assignees
@SebinSong
Labels
App:Frontend Kind:Enhancement Improvements, new features, performance upgrades, etc. Note:UI/UX Priority:High

Comments

@taoeffect
Copy link
Member

Problem

We don't have a way to zoom the pictures to view them more closely.

Solution

Create a picture viewer so that when a picture attachment clicked (or tapped) then it is shown in a view in more detail similar to how other apps do it.

On mobile it should be very simple - simply make the picture full screen and make it possible to pinch to zoom in and out.
@taoeffect taoeffect added Kind:Enhancement Improvements, new features, performance upgrades, etc. App:Frontend Priority:High Note:UI/UX labels Sep 13, 2024
@SebinSong
Copy link
Collaborator

SebinSong commented Sep 18, 2024 •
edited
Loading

@taoeffect
I'm referencing Slack's image viewer and it has 200% as the maximum zoom-in limit for all cases, regardless of how big/small the intrinsic image size is.

image

That's when it's viewed on desktop and on mobile-app it seems to allows more zoom-in (it's not sure as it doesn't show the in-app slider UI on mobile-app but it feels like 300 or 400%).

What do we want as the maximum value in our app?

@taoeffect
Copy link
Member Author

Let's go with 400% and if you feel that doesn't work well feel free to pick a value that you like better

SebinSong added a commit that referenced this issue Sep 29, 2024
@SebinSong
Merge remote-tracking branch 'origin/master' into sebin/task/#2347-cr…
5c7b1cc 
…eate-picture-viewer
@SebinSong SebinSong linked a pull request Oct 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SebinSong SebinSong

Labels
App:Frontend Kind:Enhancement Improvements, new features, performance upgrades, etc. Note:UI/UX Priority:High
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2347 - Build Image viewer in the app okTurtles/group-income
2 participants
@taoeffect @SebinSong