You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Sounds like a really interesting feature @withlin
Regarding implementation, I think we should consider changing the current logic of specifying the target binary via OTEL_TARGET_EXE to logic like:
I think changing the behavior to this will allow us to both remove the OTEL_TARGET_EXE config and support daemon set deployment at the same time. Basically, when deployed as a daemon set with hostPID: true /proc will simply contain more processes and the instrumentation agent does not even aware of the fact that it is currently deployed as a daemon set.
What do you think?
Sounds like a really interesting feature @withlin
Regarding implementation, I think we should consider changing the current logic of specifying the target binary via
OTEL_TARGET_EXE
to logic like:I think changing the behavior to this will allow us to both remove the
OTEL_TARGET_EXE
config and support daemon set deployment at the same time. Basically, when deployed as a daemon set withhostPID: true
/proc will simply contain more processes and the instrumentation agent does not even aware of the fact that it is currently deployed as a daemon set.What do you think?
Originally posted by @edeNFed in #9 (comment)
The text was updated successfully, but these errors were encountered: