Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS deployments should have a test deployment stage #142

Open
dra27 opened this issue Sep 21, 2022 · 2 comments
Open

AWS deployments should have a test deployment stage #142

dra27 opened this issue Sep 21, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@dra27
Copy link
Contributor

dra27 commented Sep 21, 2022

Before pushing to AWS for opam.ocaml.org and ocaml.org, the container should be tested on a non-live service to ensure that it starts. If that stage fails, then the deployment itself doesn't proceed, and the website(s) remain at the previous deployment (with the issue picked up on the firehose).

@tmcgilchrist tmcgilchrist added the enhancement New feature or request label Sep 21, 2022
@tmcgilchrist
Copy link
Member

tmcgilchrist commented Sep 21, 2022

For AWS Fargate we should look into the health checks support for load balancers and use that to progressively update the containers. The deployer would notify a new image is available and the AWS machinery swaps in new containers running that image (testing using the health checks) before committing to using the new version. It does also handle rollback automatically on failing health checks.

If we choose not to use AWS, we could build this support into deployer itself.

@mtelvers
Copy link
Member

In testing this afternoon, Fargate does not stop the existing containers until the new ones pass the load balancer health check. Therefore, when a faulty image is deployed, the original image remains running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants