Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Historical NDBC stations #161

Open
SorooshMani-NOAA opened this issue Sep 12, 2024 · 5 comments
Open

Historical NDBC stations #161

SorooshMani-NOAA opened this issue Sep 12, 2024 · 5 comments
Assignees
Labels

Comments

@SorooshMani-NOAA
Copy link
Contributor

In #146 historical stations are not yet implemented. See:

https://github.com/CDJellen/ndbc-api/blob/a4786307869d753e07c3413f1e1c0cf47f418ea2/ndbc_api/ndbc_api.py#L256

@tomsail
Copy link
Contributor

tomsail commented Sep 13, 2024

I had a look on the faq: https://www.ndbc.noaa.gov/faq/measdes.shtml:

  • Realtime (the current implementation) is limited to the last 45days.
  • Historical is older than 45days

It seems we can get both data with get_data() function in NDBCApi.

@SorooshMani-NOAA
Copy link
Contributor Author

Yes, but the station list that we get right now is only from the active stations, not the historical ones (stations vs historical_stations).

@SorooshMani-NOAA
Copy link
Contributor Author

SorooshMani-NOAA commented Sep 13, 2024

Some of these capabilities are very recently added to the upstream NDBC_API code, so it requires the latest version of API to work. So maybe it makes sense to go ahead with #146 first and later address this ticket. Previously (since 2 weeks ago?) there was a single stations query that addressed both!

@tomsail
Copy link
Contributor

tomsail commented Sep 13, 2024

ok indeed.
I think then it'd make sense to pin/limit the version of NDBCApi and merge #146

@SorooshMani-NOAA
Copy link
Contributor Author

Yes, it's already pinned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants