Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to annotate pods on change using a different label #126

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rtnpro
Copy link

@rtnpro rtnpro commented Nov 12, 2023

This change allows users to optionally specify a different label (than the one used to watch receiver pods) for annotating pods on hashring change.

This is useful in a separate Thanos receiver router and ingestor setup: https://thanos.io/tip/proposals-accepted/202012-receive-split.md/ where we need to watch a different set of ingestor pods to update the hashring, but the hashring is consumed by a different set of router pods.

Fixes #125

@philipgough
Copy link
Collaborator

@rtnpro would you mind rebasing on main

@rtnpro
Copy link
Author

rtnpro commented Jun 28, 2024

@philipgough I have rebased this PR on top of latest main

This change allows users to optionally specify a different label (than the
one used to watch receiver pods) for annotating pods on hashring change.

This is useful in a separate Thanos receiver router and ingestor setup:
https://thanos.io/tip/proposals-accepted/202012-receive-split.md/ where
we need to watch a different set of ingestor pods to update the hashring,
but the hashring is consumed by a different set of router pods.

Signed-off-by: Ratnadeep Debnath <[email protected]>
@rtnpro rtnpro force-pushed the annotate-diff-pods-on-change branch from 4e16979 to 54a6f39 Compare June 28, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support annotating pods on change for thanos receiver router and ingestor setup
2 participants