Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New relation request: has substrate #230

Closed
cmungall opened this issue Apr 30, 2018 · 11 comments
Closed

New relation request: has substrate #230

cmungall opened this issue Apr 30, 2018 · 11 comments
Labels
GO Related to Gene Ontology (GO) new term request

Comments

@cmungall
Copy link
Contributor

cmungall commented Apr 30, 2018

proposal outlined here
https://docs.google.com/document/d/1QMhs9J-P_q3o_rDh-IX4ZEnz0PnXrzLRVkI3vvz8NEQ/edit

@phismith
Copy link

3 Introduce new sub-relation has-substrate

"p has substrate c iff p has-input c, and..."
Characteristics: Functional (a process cannot have two substrates)

Suggestion:

"p has substrate c
= def.
#p realizes function f at t & f has material basis c at t

@dosumis
Copy link
Contributor

dosumis commented Jul 13, 2018

Characteristics: Functional (a process cannot have two substrates)

Not sure about this. Where does it come from? When a catalysed reaction has two inputs, how do we decide which is the substrate?

My favoured definition of has_substrate (not completely formalised).

p has_substrate c iff p is a catalytic process and c is transformed or destroyed as a result of p

Potential advantages:
clear; easy to apply; reasonable, based on usage of term (although see below).

Potential disadvantages (from discussion here: https://docs.google.com/document/d/1QMhs9J-P_q3o_rDh-IX4ZEnz0PnXrzLRVkI3vvz8NEQ/edit#bookmark=id.m04z9f7hl36d)

  • Too narrow?: Doesn't cover a common use of substrate to denote the substance transported by a transporter.
    OBJECTION: I think the narrower usage I'm suggesting is reasonable allows us to be more precise.

  • Too broad?: In a Protein Kinase reaction, ATP is destroyed and the protein is transformed. Under some usages of 'substrate' only the protein would be considered a substrate.
    OBJECTION: I'm not sure we can formalise this distinction. I think it is not unreasonable to call both substrates. I'd be interested to get a biochemist's take vs a molecular biologist's on the protein kinase example.

@cmungall
Copy link
Contributor Author

cmungall commented Jul 13, 2018 via email

@cmungall
Copy link
Contributor Author

Was responding to @dosumis without seeing @phismith's comment.

Barry suggests:

"p has substrate c =def p realizes function f at t & f has material basis c at t"

From my reading of section 3.7.8 in BFO2 reference this doesn't correspond to the intent of this relation, but it may help to have function elucidations in 3.7.8 as well as 'plain' dispositions.

Note: I have an outstanding ticket seeking clarification on has-material-basis on the BFO tracker: BFO-ontology/BFO#113 (was sidetracked a bit by discussion of fields, which is a different matter)

@cmungall
Copy link
Contributor Author

I asked for an elucidation here: BFO-ontology/BFO#219 - I think this one is for you @phismith

@LEHunter
Copy link

I am confused by Barry's suggestion, "p has substrate c =def p realizes function f at t & f has material basis c at t.” Don’t all the participants together form the material basis for the realized function? Even if one were going to pull out a single material basis for realizing the function, I would think it would be the catalyst, not the (intuitively understood) “substrate".

@LEHunter
Copy link

With regard to David O-S's narrowness concern, that "p has_substrate c iff p is a catalytic process and c is transformed or destroyed as a result of p” excludes entities transported, one could either define a separate relation (has_cargo?) or refine the definition to include "...and c is transformed, translocated, or destroyed as a result..." If the latter, one could define sub-relations has_cargo and has_reaction_substrate if that would be useful.

@LEHunter
Copy link

With regard to David O-S's broadness concern, that both the kinase and the ATP are substrates of a protein kinase reaction, I agree that this doesn't bother me much. However, if one wanted to hew more closely to biologists' common usage, one could create a defined class of either ubiquitous_substrates (perhaps a cardinality restriction) or energy_contributing_substrates and exclude them from the range of the relationship. Seems unwieldy and probably unnecessary, but could be done.

@cmungall
Copy link
Contributor Author

Don’t all the participants together form the material basis for the realized function?

I'm not sure - certainly from an intuitive interpretation of the term "material basis", all participants are both material and required. But the BFO docs explain material bases purely in terms of dispositions (AFAICT).

Even if one were going to pull out a single material basis for realizing the function, I would think it would be the catalyst, not the (intuitively understood) “substrate".

+1

@cmungall
Copy link
Contributor Author

See PR for two sub-relations of has-input and has-output #291

This lessens the need for an explicit has-substrate relation

@nlharris nlharris added new term request GO Related to Gene Ontology (GO) labels Oct 15, 2020
@wdduncan
Copy link
Collaborator

wdduncan commented Jan 5, 2023

This issue is being closed because it has not had any activity in the last 2 years. If you think it is still worth pursuing, please reopen the issue and comment on its status.

@wdduncan wdduncan closed this as completed Jan 5, 2023
@wdduncan wdduncan closed this as not planned Won't fix, can't repro, duplicate, stale Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GO Related to Gene Ontology (GO) new term request
Projects
None yet
Development

No branches or pull requests

6 participants