Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uPheno 2: Alpha review #18

Open
matentzn opened this issue Jan 27, 2020 · 5 comments
Open

uPheno 2: Alpha review #18

matentzn opened this issue Jan 27, 2020 · 5 comments
Assignees

Comments

@matentzn
Copy link
Contributor

matentzn commented Jan 27, 2020

@matentzn matentzn self-assigned this Jan 27, 2020
@matentzn
Copy link
Contributor Author

matentzn commented Feb 12, 2020

Ameded:

  • Need to remove "has phenotype affecting OWL:thing" assertions (fix in relation module)
  • There are some unconnected classes in the final artefact, like
  • the NBO behavior phenotype branch is pulled in because of HPO classes inhering in them.
  • All lesion terms are floating.. Need to be careful not to destroy the classification with the blacklist!
  • We need the phenotype root annotation for OLS
  • uPheno has now a whooping 8 cell classes:

image

  • There are still a significant number of references to obsolete classes

@matentzn
Copy link
Contributor Author

Should there be reasoning after the SS components are merged in - this may confuse users of them.

@matentzn
Copy link
Contributor Author

Need to be carefully with the assumption that root phenotypes are abnormal - in the case of MP, they are not!

@matentzn
Copy link
Contributor Author

matentzn commented Feb 12, 2020

Why does http://purl.obolibrary.org/obo/PHIPO_0000274 have no valid EQ?
-- because I did not yet dare to overwrite the matches! Should do that!

@matentzn
Copy link
Contributor Author

upheno:phenotype and upheno:phenotype by species should be unqualified phenotypes. We only care about abnormal phenotypes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant