Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZFA/Uberon mapping errors #3353

Open
gouttegd opened this issue Sep 4, 2024 · 0 comments · May be fixed by #3361
Open

ZFA/Uberon mapping errors #3353

gouttegd opened this issue Sep 4, 2024 · 0 comments · May be fixed by #3361
Assignees
Labels

Comments

@gouttegd
Copy link
Collaborator

gouttegd commented Sep 4, 2024

Two of the root unsatisfiable classes found in the merge product of Uberon and ZFA are caused by what are likely simple “mapping errors“, where a ZFA term has been mapped to the wrong Uberon term.

'griseum centrale'

'griseum centrale' in ZFA is part_of the 'medulla oblongata', itself part_of the hindbrain.

But it is mapped to Uberon’s 'central gray substance of midbrain', which is part of, well, the midbrain (which in Uberon is spatially disjoint with the hindbrain, hence the unsatisfiability of 'griseum centrale').

'griseum centrale' should probably be mapped instead to 'central gray substance of medulla', which is part_of the 'medulla oblongata'.

coelom

coelom in ZFA is a 'multi-tissue structure', and therefore a material entity (though the text definition says it is a “anatomical space”, confusingly enough).

It is mapped to Uberon’s 'coelemic cavity lumen', which is an 'anatomical cavity' and ultimately an immaterial anatomical entity.

It should be mapped instead to Uberon’s coelom, which is also defined as 'multi-tissue structure' and therefore a material entity (the term refers to “the aggregate of the coelemic cavity lumen plus the membranes that line the lumen”).

@gouttegd gouttegd self-assigned this Sep 4, 2024
gouttegd added a commit that referenced this issue Sep 12, 2024
ZFA's 'griseum centrale' (ZFA:0000518) is mapped to Uberon's 'central
gray substance of midbrain' (UBERON:0003040).

This is likely incorrect as the ZFA term refers to a structure that is
part of the hindbrain, whereas the Uberon term refers to a midbrain
structure.

The correct mapping is most likely 'central gray substance of medulla'
(UBERON:0002867), which is part of the hindbrain.

partially addresses #3353
gouttegd added a commit that referenced this issue Sep 12, 2024
ZFA's 'coelom' (ZFA:0001438) is mapped to Uberon's 'coelemic cavity
lumen' (UBERON:0002323).

This is incorrect as the ZFA terms refers to a multi-tissue structure
and therefore to a material entity, whereas the Uberon term refers to
the anatomical cavity *within* the coelom (an immaterial entity).

Uberon has another term to refer to the (material) anatomical structure
that forms the coelemic cavity: 'coelom' (UBERON:0011997), the ZFA term
should be mapped to that term instead.

partially addresses #3353
@gouttegd gouttegd linked a pull request Sep 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant