-
Notifications
You must be signed in to change notification settings - Fork 8
Find a way to make this work in the desktop apps #3
Comments
I'm thinking of making a daemon using systray and having it run automatically on startup (with options to disable that from the menubar icon) |
Hey! I work on the notion-enhancer, a script that mods the desktop app to add custom theming and scripting. I'm working on transitioning it from a simple mod to a proper mod-loader, and I was hoping to be able to include this as a mod (you'd be properly attributed for it, of course). If that's alright with you, please let me know as soon as possible :) |
Hey @dragonwocky, thanks a lot for that, that would be wonderful! I'd love to have this mod included there! |
Implemented/working and will be included in the update once it's released in a couple days! Including the improvements from #11 and simplified a bit to remove unnecessary code, it all boils down to this: https://github.com/dragonwocky/notion-enhancer/blob/js/mods/right-to-left/mod.js#L19-L44 |
@dragonwocky Thanks for your work my implementation in the PR is slightly more performant : https://stackoverflow.com/a/39332340/6938643 -> give this answer a read hope it will be helpful :) |
@Fahme did some performance work with a Admittedly it only aligns right within the database as screenshotted after hovering, I don't know what's going on there. Everywhere else it seems to just work, though. |
@dragonwocky there's alot of things that needs to be done for the DB RTL support not only the text but also the buttons that overlay on text, table items, input items etc .. probably will need to find a better way than currently to support and fix major issues in #1 as well or else this extension is not very practical for full RTL support IMO |
it's definitely not perfect, but it's better than nothing. the enhancer is all about improving notion in the ways it can until a better way appears. over time, improvements will be made until notion has support builtin. |
https://github.com/dragonwocky/notion-enhancer/ |
@obahareth I'm on the latest notion-enhancer (Mac) |
@alonidel the version in notion-enhancer is extremely buggy at the moment, and though it was based on this currently has very different code. it's better to ask support for it in the notion-enhancer repo. |
I think this issue can be closed: I'm now using a more direct implementation of @Fahme's code, which works reliably and solves the above problem. |
@all-contributors please add @dragonwocky for platform contributions. |
I've put up a pull request to add @dragonwocky! 🎉 |
Sorry guys can you guide me how to use RTL in Notion Enhanced in Linux ver ? |
@DSparda it's bugged at the moment, it will be fixed in the next update. For a temporary fix, check out notion-enhancer/notion-enhancer#589 |
I tried making a script in Go that includes the script in
~/Library/"Application Support"/Notion/assetCache/{version}/index-*.html
(on macOS) and it works, however that file gets deleted when relaunching Notion. I also tried unpacking the app.asar from inside/Applications/Notion.app
and including that script inrenderer/index.html
(and even just tossing an H1 there), but it appears that HTML file is only used when launching the app and then a new one is downloaded from the website.Here's the script tag for reference
Approaches I'm considering:
Application Support/Notion/assetCache
directory and re-inject the tag as necessary.The text was updated successfully, but these errors were encountered: