Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arduino language support request #1171

Closed
1 task done
Sh4rk-Byte opened this issue Sep 18, 2023 · 15 comments
Closed
1 task done

Arduino language support request #1171

Sh4rk-Byte opened this issue Sep 18, 2023 · 15 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Sh4rk-Byte
Copy link
Contributor

Language Name πŸ–Š

Arduino (.ino files)

Logo πŸ“·

No response

Upstream support βœ…

  • Does tokei already support the language in question?
@Sh4rk-Byte Sh4rk-Byte added enhancement New feature or request good first issue Good for newcomers labels Sep 18, 2023
@spenserblack
Copy link
Collaborator

Thanks for the request! Would you be willing to create your own ASCII art?

Also, FYI πŸ˜‰

@Sh4rk-Byte
Copy link
Contributor Author

ascii-art.txt

There's the ASCII art, it's supposed to be this color: #189ba1.

@spenserblack
Copy link
Collaborator

(Posting the ASCII art in the comments for easier access)

                                       --+++++++++++++++++++-                                       
                                --+++++++++++++++++++++++++++++++++-                                
                            -+++++++++++++++++++++++++++++++++++++++++++                            
                         ++++++++++++++++++++++++++++++++++++++++++++++++++                         
                      ++++++++++++++++++++++++++++++++++++++++++++++++++++++++                      
                   ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++                   
                 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++                 
               ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++               
             ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++             
            ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++            
          ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++          
         ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++         
       -+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++       
      -+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++      
     ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++     
    -+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++    
    +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++   
   +++++++++++++++++++++++++------++++++++++++++++++++++++++++++++------+++++++++++++++++++++++++   
  ++++++++++++++++++++--.            .--++++++++++++++++++++--.            .--++++++++++++++++++++  
  +++++++++++++++++-..                  ..-++++++++++++++-..                  ..-+++++++++++++++++  
 ++++++++++++++++-.                        .-++++++++++-.                        .-++++++++++++++++ 
-+++++++++++++++.        ..-++++++-..        .-++++++-.        ..-++++++-..        .++++++++++++++++
++++++++++++++-.      .-++++++++++++++-.       .++++.       .-++++++++++++++-.      .-++++++++++++++
++++++++++++++.     .-++++++++++++++++++-.      .--.      .-++++++++++++++++++-.     .++++++++++++++
+++++++++++++.     .-+++++++++++++++++++++-              -+++++++++...-++++++++-.     .+++++++++++++
++++++++++++-     .-++++++++++++++++++++++++.          .+++++++++++.  -+++++++++-.     -++++++++++++
++++++++++++.     .+++++++-----------++++++++-.      .-++++++++----.  .---+++++++.     -++++++++++++
++++++++++++.     .++++++-.         .+++++++++.      .+++++++++.         .-++++++.     .++++++++++++
++++++++++++.     .++++++--.........-++++++++-.      .-++++++++-....  .---+++++++.     -++++++++++++
++++++++++++-     .-++++++++++++++++++++++++.          .+++++++++++.  -+++++++++-.     -++++++++++++
+++++++++++++.     .-+++++++++++++++++++++-              -+++++++++...-+++++++++.     .+++++++++++++
++++++++++++++.     .-++++++++++++++++++-.      .--.      .-++++++++++++++++++-.     .++++++++++++++
++++++++++++++-.      .-++++++++++++++-.       .++++.       .-++++++++++++++-.      .-++++++++++++++
-+++++++++++++++.       ...-++++++-...       .-++++++-.       ...-++++++-...       .++++++++++++++++
 ++++++++++++++++-.                        .-++++++++++-.                        .-++++++++++++++++ 
  +++++++++++++++++-..                  ..-++++++++++++++-..                  ..-+++++++++++++++++  
  ++++++++++++++++++++--.            .--++++++++++++++++++++--.            .--++++++++++++++++++++  
   +++++++++++++++++++++++++------+++++++++++++++++++++++++++++++++-----+++++++++++++++++++++++++   
    +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++   
    ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++    
     ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++     
      -+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++      
       -+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++       
         ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++         
          ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++          
            +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++           
             ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++             
               ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++               
                 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++                 
                   -+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++                   
                      ++++++++++++++++++++++++++++++++++++++++++++++++++++++++                      
                         ++++++++++++++++++++++++++++++++++++++++++++++++++                         
                            -+++++++++++++++++++++++++++++++++++++++++++                            
                                 -+++++++++++++++++++++++++++++++++                                 
                                       --+++++++++++++++++++-                                       

#189ba1

Love the ASCII art! But we set a limit for width and height, and just looking at this it's a little big. Would you want to make a pull request? No Rust experience needed!

@Sh4rk-Byte
Copy link
Contributor Author

I'm sorry but I'm not that expirienced in using GitHub, I don't know how to make a pull request on a public repo

@spenserblack
Copy link
Collaborator

Got it, no pressure.

I'm going to mark this as "help wanted" to open this issue up for anyone else to contribute. But making a PR is easy (IMO).

  1. Go to the repo's homepage and click the "fork" button
  2. In your fork, create a new branch (optional)
  3. Make your changes
  4. GitHub should be smart enough to notice you've made changes and prompt you to create a PR. If not, you can go to this link to create a PR.

You might want to check this out: https://github.com/skills/introduction-to-github

But no pressure if you don't want to πŸ™‚

@spenserblack spenserblack added the help wanted Extra attention is needed label Sep 18, 2023
@spenserblack
Copy link
Collaborator

Off-topic: @o2sh The emojis in labels are pretty, but it looks like we're not discoverable by sites like https://goodfirstissues.com. Just an FYI

@Sh4rk-Byte
Copy link
Contributor Author

And by making changes you mean adding the ASCII art txt file?

@spenserblack
Copy link
Collaborator

We have contributing guidelines in CONTRIBUTING.md. It's a pretty standard filename, so if you're looking to contribute to a repo, checking if this file exists is a good place to start.

Basically, languages.yaml defines everything we need to add a new language. So you can edit that file in your fork and make a PR. Don't worry if you're not confident about your changes -- we can offer feedback in the PR.

And when we merge your PR you can brag about being a contributor for onefetch πŸ˜‰

@Sh4rk-Byte
Copy link
Contributor Author

Ok, but how do I create PR on this repo, when I did the edits in my forked one?

@spenserblack
Copy link
Collaborator

When creating a PR you can change the base repository, which could also be thought of as the target repository. I went ahead and made the PR for you, though πŸ˜‰ #1173

@Sh4rk-Byte
Copy link
Contributor Author

Oh I overlooked that thank you. So other than the review it's done?

@spenserblack
Copy link
Collaborator

Yeah pretty much. You might want to subscribe to #1173 so you're notified when we add comments.

@o2sh
Copy link
Owner

o2sh commented Sep 18, 2023

Off-topic: @o2sh The emojis in labels are pretty, but it looks like we're not discoverable by sites like https://goodfirstissues.com/. Just an FYI

Thanks for pointing that out @spenserblack, I created an issue on their repo iedr/goodfirstissues#57

@spenserblack
Copy link
Collaborator

Thanks for finding the repo!

Looks like this is the relevant query: https://github.com/iedr/goodfirstissues/blob/36dde6c91654287fc84eaf657dfcce0eccf72284/backend/main-to-file.go#L68-L81

@spenserblack
Copy link
Collaborator

Closed in #1176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants