Sync code with .env in build.rs #4876
Conversation
dynco-nym
force-pushed
the
dz-sync-network-defaults-vars
branch
from
7c9059d
to
c7e8272
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
There was a problem hiding this comment.
I think this is a great idea!
Seeing this I realize that the mainnet default use for nym-vpi-api is wrong, it should be nymvpn.com not .net, so that's great that this code caught that :)
Put in some comments that I think it would be good to make it error if the directory is not correct (due e.g the crate being moved or built from somewhere else). For example what happens when you package this crate using cargo package? Another option here is move this code to a unit test that confirms that the file contents match the env file?
| use regex::Regex; | ||
| use std::{collections::HashMap, fs}; | ||
|
|
||
| const TARGET_ENV_FILE: &str = "../../envs/mainnet.env"; |
There was a problem hiding this comment.
I wonder about this, do you think it's possible to make this relative to the repo root directory? Soon I would like to move the root Rust workspace to a subdirectory to avoid the workspace nesting, and this would then break
Also put in a check that we are writing to the directory we think we are. So that it doesn't try to write the file unless the directory path is correct
dynco-nym
force-pushed
the
dz-sync-network-defaults-vars
branch
from
c7e8272
to
3ca2620
Compare
Keep dotenv file always up to date
... and we already see its use case :)
This change is