Incorrect handling of borders when resizable is false

[sysrage]

NWJS Version : 0.47
Operating System : Windows 10 18363.900

Expected behavior

When a window's resizable property is set to false, the window frame/border/etc. should not start showing black outside borders and other odd artifacts.

Actual behavior

When resizable is set to false, windows are incorrectly gaining an outer black border on the sides and bottom. They're also gaining a 'border' between the titlebar and the window content which causes several issues. If you mouseover the close button, the button is highlighted red (as expected). When moving the mouse away, the bottom 'border' remains red. This also results in the titlebar being "too short" when content is covering the "top border".

How to reproduce

Set resizable to false for any window, either through the window options when opening it or by using setResizable(). Easiest reproduction:

1. Launch nw.exe (SDK build) with no script/HTML.
2. Open console and run: window.nw.Window.get().setResizable(false);
3. Immediately observe the outer black border and incorrect lighter-grey top border.
4. Mouseover the close button to observe the red being 'stuck' in the incorrect top border.

[sysrage]

This appears to have been broken in version 0.42.4 of NW.js. I can reproduce this issue with 0.42.4 but not with 0.42.3.

[sysrage]

This also does NOT occur when running NW.js 0.47 with --disable-features=nw2. Adding as a blocking bug for removing NW1 (#7230 ).

[rogerwang]

This is fixed in git and available in the nightly build.

[sysrage]

Thanks! I've verified that this fixes the borders as reported in this bug. Unsure if you're leaving bugs open until an official release, but this can be closed.