Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NW2 Standard alert/confirm.. clip in main window #7422

Closed
DrDoing opened this issue Mar 23, 2020 · 1 comment
Closed

NW2 Standard alert/confirm.. clip in main window #7422

DrDoing opened this issue Mar 23, 2020 · 1 comment

Comments

@DrDoing
Copy link

DrDoing commented Mar 23, 2020

#7230 @rogerwang

NWJS Version : since 0.44.2 and nw2 is default
Operating System : Windows

Expected behavior

If you show a javascript dialog like alert/confirm prior to 0.44.2
the msgbox was shown on the desktop.
Since 0.44.2 (nw2) the messagebox is shown inside the main
window. If the main window is to smal in width, the messageboxes
will be clipped.

Exampe-nw1-nw2.zip
20200323-03

<!- What do you think should happen? ->
In nwjs >= 0.44.2 (nw2) the messageboxes should not be clipped by the main window.

Actual behavior

Messageboxes will be cliped if the size of the main window ist to smal.
<!- What actually happens? ->

How to reproduce

above there is a Exampe-nw1-nw2.zip File.
inside there are 2 directorys:
..
nw1\index.html
nw1\package.json
...
nw2\index.html
nw2\package.json
..
nw1 has a fix in package.json to disable nw2
first copy both files of nw1 in a nwjs main directory and start nw.exe
Resize the window to minimal witdh (about 100 to 200 pixel if possible)
Click on the button "Please Click"
There will be shown 2 message boxes in correct size.
end nw.exe

second copy both files of nw2 in a nwjs main directory and start nw.exe
Resize the window to minimal witdh (about 100 to 200 pixel if possible)
Click on the button "Please Click"
There will be shown 2 message boxes cliped in size (width)
end nw.exe

@rogerwang
Copy link
Member

This is fixed in git and will be available in the next nightly build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants