-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NW2] Steam Overlay is drawn over NWjs window title bar #7362
Comments
I've further investigated this issue and below are my findings. Turns out it was working in NW1 in the past, broke somewhere along the way and completely broke in NW2. (Tagging #7230.) NWjs 0.38.0+ [NW1] (couldn't test on v0.37.0 because --in-process-gpu was broken): |
Could you attach a picture of the NW2 window without the overlay? And could you also test Chrome browser there? Thanks. |
"Default Window" is the NW2 window without overlay. It was difficult to reproduce but it's the same behavior in Chrome. I'm 99% sure that a report to them would result in nothing (no one is using Chrome Browser to run their HTML5 Steam games, that's why NWjs exists). I'd really appreciate any help from your side if possible. |
@rogerwang I found a workaround to get the overlay working as intended using the "--disable-windows10-custom-titlebar" chromium arg. The window title buttons still don't work and the window can't be moved, when the Steam Overlay is enabled but at least it renders correctly. |
@skymen Are you sure that you disabled the custom title bar? It should look similar to the white one in the screenshot above. Try not disabling vsync, it could be in conflict with that. |
The best way for me to investigate why it isn't working on your end, would be to upload the package.nw file here. |
package.zip |
The example project doesn't seem to have a constantly refreshing canvas. I'd regardless recommend to put the "--disable-windows10-custom-titlebar" at the beginning before all other args and test if that does anything. If that doesn't work, I'd suggest trying to reproduce this with the latest version of NWjs. |
Indeed, putting the flag at the start of the list, before everything else seems to have fixed it. |
If you got time. Maybe you can shift it 1 place at a time to find out which other arg it's in conflict with. This could be an NWjs issue that can fixed. |
I'll try that but with a binary search type algorithm, it'll be much faster to find out I think. EDIT: It only bugs out when I put it last, after --disable-direct-composition |
I don't think anything can done about this. Chromium probably executes the args from left to right (first to last) and some features are bound to others. This is probably one of those cases. (As a side note "--disable-direct-composition" should only be a last resort, if you experience major rendering issues.) |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
NWJS Version: v0.44.0
Operating System: Windows 10
Project Reproduction: Steam Overlay Test.zip
Expected behavior
The Steam Overlay should not be drawn over the title bar.
Default Window:
Steam Overlay (NW2):
Steam Overlay (NW2, after being closed):
Actual behavior
The Steam Overlay is drawn over the window title bar and also overrides all of its functions. This issue can only be reproduced in Windows 10.
How to reproduce
SHIFT + TAB
to open Steam OverlayThe text was updated successfully, but these errors were encountered: