Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Attaching image to existing disk in module ntnx_vms #454

Open
Gevorg-Khachatryan-97 opened this issue Dec 15, 2023 · 2 comments · Fixed by #505
Open

[Bug] Attaching image to existing disk in module ntnx_vms #454

Gevorg-Khachatryan-97 opened this issue Dec 15, 2023 · 2 comments · Fixed by #505
Assignees
@george-ghawali
Labels
1.9.3_triage Bug fixes & Improvements bug Something isn't working

Comments

@Gevorg-Khachatryan-97
Copy link
Collaborator

Gevorg-Khachatryan-97 commented Dec 15, 2023 •
edited
Loading

Describe the bug
Module is failing when trying to attach image to existing disk of vm.

To Reproduce
Steps to reproduce the behavior:

  1. create vm with empty cd-rom
  2. update cd-rom with clone_image attribute

Stack trace
Failing during spec generation with KeyError vms.py, line 465
@Gevorg-Khachatryan-97 Gevorg-Khachatryan-97 added the bug Something isn't working label Dec 15, 2023
@Gevorg-Khachatryan-97 Gevorg-Khachatryan-97 changed the title [Bug] Attaching image to existing empty CD-rom in module ntnx_vms [Bug] Attaching image to existing disk in module ntnx_vms Dec 15, 2023
@bhati-pradeep bhati-pradeep added the 1.9.3_triage Bug fixes & Improvements label Aug 5, 2024
@george-ghawali george-ghawali linked a pull request Sep 26, 2024 that will close this issue
Adding fix for updating empty CD ROM with clone image attribute #505
Merged
@darthVikes
Copy link

Duplicated this with

      - type: "DISK"
        bus: "SCSI"
        empty_cdrom: true

Did seem to work with:

      - type: "CDROM"
        bus: "IDE"
        empty_cdrom: true

@bhati-pradeep
Copy link
Collaborator

@george-ghawali Please check comment by @darthVikes. Please test your fix with the case given above. Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@george-ghawali george-ghawali

Labels
1.9.3_triage Bug fixes & Improvements bug Something isn't working
Projects
nutanix.ncp v1.9.3 release
Status: In Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding fix for updating empty CD ROM with clone image attribute nutanix/nutanix.ansible
6 participants
@premkarat @darthVikes @bhati-pradeep @alaa-bish @Gevorg-Khachatryan-97 @george-ghawali