upgrade packages and remove AUTHOR_EMAIL and AUTHOR_NAME because it breaks signed commit #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lowaiz
approved these changes
Sep 12, 2024
| @@ -138,16 +136,6 @@ def is_test_env(env: str) -> bool: | |||
| else int(os.environ["GITLAB_GRAPHQL_PAGE_LENGTH"]) | |||
| ) | |||
| GITLAB_GROUP_IDENTIFIER = os.getenv("GITLAB_GROUP_IDENTIFIER", "") | |||
| GITLAB_AUTHOR_EMAIL = ( | |||
There was a problem hiding this comment.
J'aurais été de l'avis de rajouter une option signed_commit, qui sera en mutual exclusive avec l'author.
Ca eviterait un changement cassant, mais en temporaire ca me va de simplement degager les 2 options.
There was a problem hiding this comment.
I agree that it’s important to apply conditions in this case, as it remains relevant in other setups as well. I'm working on proposing a change that aligns with this approach.
Co-authored-by: Lowaiz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.