Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What happens when running glue from an ipython console #42

Open
BenRussert opened this issue Apr 18, 2019 · 1 comment
Open

What happens when running glue from an ipython console #42

BenRussert opened this issue Apr 18, 2019 · 1 comment

Comments

@BenRussert
Copy link
Member

It is convenient to use an ipython console to quickly look for scraps using sb.read_notebooks, so I wondered what would happen if I try glue outside a notebook environment like this.

When I tried this, there was no error message or anything so my question is:

Should there be an error message? Does anything happen? Should something happen?

@BenRussert BenRussert changed the title What happens when running glue from an ipythong console What happens when running glue from an ipython console Apr 18, 2019
@MSeal
Copy link
Member

MSeal commented Apr 18, 2019

I think at least a warning if not an error should be raised when not connected to a zeromq channel. The only hesitation in raising an error is that users would need to branch code that side-effects a glue call when used outside of a notebook, which might be unexpected. Plus detection of such a state appears to be difficult currently, so kernel usages in other contexts could be problematic if we raised an error when we shouldn't be.

So I'd vote for a warning event so there is at least visibility into the fact that the glue action is not recording any references to data. A place to think about this more is around glue calls to remote stores. Should we still save the remote data or fail fast with an exception if we likely know that the reference will be lost?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants